netdev - Re: [patch] inetpeer: initialize ->redirect_genid in inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Jan 2012 21:57:08 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()

Le mardi 17 janvier 2012 à 23:48 +0300, Dan Carpenter a écrit :
> kmemcheck complains that ->redirect_genid doesn't get initialized.
> Presumably it should be set to zero.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
> index 86f13c67..49ce5f4 100644
> --- a/net/ipv4/inetpeer.c
> +++ b/net/ipv4/inetpeer.c
> @@ -447,6 +447,7 @@ relookup:
>  		p->rate_last = 0;
>  		p->pmtu_expires = 0;
>  		p->pmtu_orig = 0;
> +		p->redirect_genid = 0;
>  		memset(&p->redirect_learned, 0, sizeof(p->redirect_learned));
>  
> 

We dont really care, since we force redirect_learned.a4 to be 0

Only place we care is in ip_rt_redirect() and its done properly there.

Lets shutup kmemcheck.

Acked-by: Eric Dumazet <eric.dumazet@...il.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html