netdev - [REGRESSION] fix smsc911x build failure due to "net/smsc911x: Check if PHY is in operational mode before software reset"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120118173612.GM1068@n2100.arm.linux.org.uk>
Date:	Wed, 18 Jan 2012 17:36:12 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Javier Martinez Canillas <javier@...hile0.org>,
	"David S. Miller" <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: [REGRESSION] fix smsc911x build failure due to "net/smsc911x:
	Check if PHY is in operational mode before software reset"

From: Russell King <rmk+kernel@....linux.org.uk>

Commit 6386994e03ebbe (net/smsc911x: Check if PHY is in operational
mode before software reset) causes the following build errors with
ARM Versatile Express:

drivers/net/ethernet/smsc/smsc911x.c: In function 'smsc911x_phy_disable_energy_detect':
drivers/net/ethernet/smsc/smsc911x.c:1329: error: 'MII_LAN83C185_CTRL_STATUS' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1329: error: (Each undeclared identifier is reported only once
drivers/net/ethernet/smsc/smsc911x.c:1329: error: for each function it appears in.)
drivers/net/ethernet/smsc/smsc911x.c:1340: error: 'MII_LAN83C185_EDPWRDOWN' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1341: error: 'MII_LAN83C185_ENERGYON' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c: In function 'smsc911x_phy_enable_energy_detect':
drivers/net/ethernet/smsc/smsc911x.c:1364: error: 'MII_LAN83C185_CTRL_STATUS' undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1372: error: 'MII_LAN83C185_EDPWRDOWN' undeclared (first use in this function)

Adding linux/smscphy.h solves this build error.

Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
--
 drivers/net/ethernet/smsc/smsc911x.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 9d0b8ce..9aeb666 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -54,6 +54,7 @@
 #include <linux/swab.h>
 #include <linux/phy.h>
 #include <linux/smsc911x.h>
+#include <linux/smscphy.h>
 #include <linux/device.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html