netdev - Re: [PATCH] pch_gbe: Do not abort probe on bad MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120118.164145.973182321372504360.davem@davemloft.net>
Date:	Wed, 18 Jan 2012 16:41:45 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dvhart@...ux.intel.com
Cc:	linux-kernel@...r.kernel.org, arjan@...ux.intel.com,
	alan@...ux.intel.com, tomoya.rohm@...il.com,
	jeffrey.t.kirsher@...el.com, paul.gortmaker@...driver.com,
	jdmason@...zu.us, netdev@...r.kernel.org,
	broonie@...nsource.wolfsonmicro.com, David.Laight@...LAB.COM,
	joe@...ches.com
Subject: Re: [PATCH] pch_gbe: Do not abort probe on bad MAC

From: Darren Hart <dvhart@...ux.intel.com>
Date: Mon, 16 Jan 2012 11:50:19 -0800

> If the MAC is invalid or not implemented, do not abort the probe. Issue
> a warning and prevent bringing the interface up until a MAC is set manually
> (via ifconfig $IFACE hw ether $MAC).
> 
> Tested on two platforms, one with a valid MAC, the other without a MAC. The real
> MAC is used if present, the interface fails to come up until the MAC is set on
> the other. They successfully get an IP over DHCP and pass a simple ping and
> login over ssh test.
> 
> This is meant to allow the Inforce SYS940X development board:
> http://www.inforcecomputing.com/SYS940X_ECX.html
> (and others suffering from a missing MAC) to work with the mainline kernel.
> Without this patch, the probe will fail and the interface will not be created,
> preventing the user from configuring the MAC manually.
> 
> This does not make any attempt to address a missing or invalid MAC for the
> pch_phub driver.
> 
> Signed-off-by: Darren Hart <dvhart@...ux.intel.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html