netdev - Re: [PATCH net-next V3 0/2] igb: ptp hardware clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120119093906.GC4420@cherladcori01>
Date:	Thu, 19 Jan 2012 10:39:06 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	Jacob Keller <jacob.e.keller@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH net-next V3 0/2] igb: ptp hardware clock

On Sat, Jan 07, 2012 at 05:02:39PM -0800, Jeff Kirsher wrote:
> On Sat, 2012-01-07 at 20:38 +0100, Richard Cochran wrote:
> > * ChangeLog
> > ** V3
> >    - Driver compiles even without CONFIG_PTP_1588_CLOCK.
> >    - Timestamping always works, even when PTP code missing or fails.
> > ** V2
> >    - Fixed wrong bit shifting in the 82576 code.
> >    - Explained the timestamp locking with a comment in the code.
> >    - Preserved the comments from the original timecompare
> > implementation.
> >    - Added an additional test within the overflow counter code to fix
> >      a race condition. Details of the problem are given in the commit
> >      message.
...
> Thanks Richard, I will add this series to my queue.

Jeff,

Please hold off with these. I adapted the driver to use
timecounter/cyclecounter as Jacob suggested, and the result is surely
nicer. I will post a V4 after I finish testing it.

Thanks,
Richard



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html