netdev - [PATCH 1/3] skge: don't assert carrier until link is up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120119163525.764252ea@nehalam.linuxnetplumber.net>
Date:	Thu, 19 Jan 2012 16:35:25 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: [PATCH 1/3] skge:  don't assert carrier until link is up

Skge device would assert carrier (link up) as soon as network device open
was called, rather than waiting until PHY has detected link.


Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

---
This should go to -stable since reporting bogus link up can break lots of things.


--- a/drivers/net/ethernet/marvell/skge.c	2012-01-19 09:55:39.231722844 -0800
+++ b/drivers/net/ethernet/marvell/skge.c	2012-01-19 15:08:06.929771000 -0800
@@ -2576,6 +2576,7 @@ static int skge_up(struct net_device *de
 	}
 
 	/* Initialize MAC */
+	netif_carrier_off(dev);
 	spin_lock_bh(&hw->phy_lock);
 	if (is_genesis(hw))
 		genesis_mac_init(hw, port);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html