netdev - Re: [net-next-2.6 PATCH] enic: fix compile when CONFIG_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F19EF85.4040807@xenotime.net>
Date:	Fri, 20 Jan 2012 14:49:41 -0800
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Roopa Prabhu <roprabhu@...co.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH] enic: fix compile when CONFIG_PCI_IOV is
 not	enabled

On 01/20/2012 12:25 AM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roprabhu@...co.com>
> 
> reverting back change that access enic->num_vfs outside
> CONFIG_PCI_IOV
> 
> Reported-by: Randy Dunlap <rdunlap@...otime.net>
> Signed-off-by: Roopa Prabhu <roprabhu@...co.com>

Acked-by: Randy Dunlap <rdunlap@...otime.net>

Thanks.

> ---
>  drivers/net/ethernet/cisco/enic/enic_main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
> index 045c468..ab3f67f 100644
> --- a/drivers/net/ethernet/cisco/enic/enic_main.c
> +++ b/drivers/net/ethernet/cisco/enic/enic_main.c
> @@ -2273,7 +2273,7 @@ static int __devinit enic_probe(struct pci_dev *pdev,
>  #ifdef CONFIG_PCI_IOV
>  	int pos = 0;
>  #endif
> -	int num_pps;
> +	int num_pps = 1;
>  
>  	/* Allocate net device structure and initialize.  Private
>  	 * instance data is initialized to zero.
> @@ -2380,11 +2380,11 @@ static int __devinit enic_probe(struct pci_dev *pdev,
>  				goto err_out_vnic_unregister;
>  			}
>  			enic->priv_flags |= ENIC_SRIOV_ENABLED;
> +			num_pps = enic->num_vfs;
>  		}
>  	}
>  #endif
>  
> -	num_pps = enic->num_vfs ? enic->num_vfs : 1;
>  	/* Allocate structure for port profiles */
>  	enic->pp = kcalloc(num_pps, sizeof(*enic->pp), GFP_KERNEL);
>  	if (!enic->pp) {
> 
> --


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html