netdev - Re: [PATCH 3/3] skge: add byte queue limit support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120122.142501.1342631979051946828.davem@davemloft.net>
Date:	Sun, 22 Jan 2012 14:25:01 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] skge: add byte queue limit support

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 20 Jan 2012 07:23:44 +0100

> Le jeudi 19 janvier 2012 à 16:43 -0800, Stephen Hemminger a écrit :
>> This also changes the cleanup logic slightly to aggregate
>> completed notifications for multiple packets.
>> 
>> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
>> 
>> --- a/drivers/net/ethernet/marvell/skge.c	2012-01-19 16:12:19.000000000 -0800
>> +++ b/drivers/net/ethernet/marvell/skge.c	2012-01-19 16:42:17.675908798 -0800
>> @@ -2831,6 +2831,7 @@ static netdev_tx_t skge_xmit_frame(struc
>>  		netif_stop_queue(dev);
>>  	}
>>  
>> +	netdev_sent_queue(dev, skb->len);
> 
> 
> I doubt this is safe, as skb might already be freed by tx completion
> handler from another cpu.

Oops, I'll not apply this for now then.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html