netdev - Re: ethtool: allow ETHTOOL_GSSET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327281557.8004.137.camel@deadeye>
Date:	Mon, 23 Jan 2012 01:19:17 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
CC:	<netdev@...r.kernel.org>
Subject: Re: ethtool: allow ETHTOOL_GSSET_INFO for users

On Sun, 2012-01-22 at 11:20 +0100, Michał Mirosław wrote:
> Allow ETHTOOL_GSSET_INFO ethtool ioctl() for unprivileged users.
> ETHTOOL_GSTRINGS is already allowed, but is unusable without this one.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
Acked-by: Ben Hutchings <bhutchings@...arflare.com>

We should probably also add:

ETHTOOL_GLINK
ETHTOOL_GRXFHINDIR
ETHTOOL_GCHANNELS

Ben.

> ---
>  net/core/ethtool.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> [against net, but probably suitable for stable, too]
> 
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index 921aa2b..369b418 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -1311,6 +1311,7 @@ int dev_ethtool(struct net *net, struct ifreq *ifr)
>  	case ETHTOOL_GRXCSUM:
>  	case ETHTOOL_GTXCSUM:
>  	case ETHTOOL_GSG:
> +	case ETHTOOL_GSSET_INFO:
>  	case ETHTOOL_GSTRINGS:
>  	case ETHTOOL_GTSO:
>  	case ETHTOOL_GPERMADDR:

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html