netdev - Re: [PATCH 1/1] dsa: Add reporting of silicon revision for Marvell 88E6123/88E6161/88E6165 switches.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120123.135940.341602114077968006.davem@davemloft.net>
Date:	Mon, 23 Jan 2012 13:59:40 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	florian@...nwrt.org
Cc:	cphealy@...il.com, ben@...adent.org.uk, buytenh@...tstofly.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] dsa: Add reporting of silicon revision for Marvell
 88E6123/88E6161/88E6165 switches.

From: Florian Fainelli <florian@...nwrt.org>
Date: Mon, 23 Jan 2012 10:48:10 +0100

> On 01/23/12 08:20, Chris Healy wrote:
>> +		if ((ret&  0xfff0) == 0x1650)
>>   			return "Marvell 88E6165";
>>   	}
> 
> What about a switch/case here?

I don't think you can express "(ret&  0xfff0) == 0x1650)" using
a switch statement.

But BTW, the formatting of that expression needs to be cleaned up.
It should be "(ret & 0xfff0) == 0x1650)"
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html