netdev - Re: [PATCH] tg3: fix ipv6 header length computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120123.142550.882140949914528850.davem@davemloft.net>
Date:	Mon, 23 Jan 2012 14:25:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	mcarlson@...adcom.com, mchan@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH] tg3: fix ipv6 header length computation

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 23 Jan 2012 12:22:09 +0100

> tg3_start_xmit() makes the wrong assumption for TSOV6 that skb->head
> doesnt include any payload data.
> 
> if (skb_is_gso_v6(skb))
> 	hdr_len = skb_headlen(skb) - ETH_HLEN;
> 
> This is not true anymore after commit f07d960df3 (tcp: avoid frag
> allocation for small frames)
> 
> We should instead use : skb_transport_offset(skb) + tcp_hdrlen(skb)
> 
> Its also true for IPv4
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Matt Carlson <mcarlson@...adcom.com>
> CC: Michael Chan <mchan@...adcom.com>
> ---
> I dont have a compatable hardware (5755_PLUS ?) so please guys test
> this...

I've applied this, if testing finds problems we can fix it up or revert.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html