netdev - Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327353339.2587.7.camel@edumazet-laptop>
Date:	Mon, 23 Jan 2012 22:15:39 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"Pradeep A. Dalvi" <netdev@...deepdalvi.com>
Cc:	Joe Perches <joe@...ches.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to
 netdev_alloc_skb

Le mardi 24 janvier 2012 à 02:11 +0530, Pradeep A. Dalvi a écrit :

> Aah! Is that really needed? Cause from my understanding, priority GFP
> flag __GFP_DMA is anyway negated in __alloc_skb, in a way from all
> sources i.e. netdev_alloc_skb or dev_alloc_skb or even alloc_skb. Am I
> missing something here?

You should read the whole __alloc_skb() function and not only half of
it.

skb itself is allocated in the normal memory pool, (not GFP_DMA), since
it has no hardware requirement for a kernel structure.

But skb->head _is_ allocated with GFP_DMA if driver requested it.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html