netdev - Re: [PATCH net-next] net: flow_dissector.c missing include linux/export.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327421731.7231.19.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Tue, 24 Jan 2012 17:15:31 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	jdb@...x.dk
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH net-next] net: flow_dissector.c missing include
 linux/export.h

Le mardi 24 janvier 2012 à 16:57 +0100, Jesper Dangaard Brouer a écrit :
> The file net/core/flow_dissector.c seems to be missing
> including linux/export.h.
> 
> Signed-off-by: Jesper Dangaard Brouer <hawk@...x.dk>
> ---
>  net/core/flow_dissector.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 0985b9b..a225089 100644
> --- a/net/core/flow_dissector.c
> +++ b/net/core/flow_dissector.c
> @@ -1,4 +1,5 @@
>  #include <linux/skbuff.h>
> +#include <linux/export.h>
>  #include <linux/ip.h>
>  #include <linux/ipv6.h>
>  #include <linux/if_vlan.h>


Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Hmm, not sure how you found this, since export.h is included from
linux/netdevice.h (via net/netprio_cgroup.h & linux/module.h)

Or maybe you want to remove linux/module.h inclusion from
net/netprio_cgroup.h ???



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html