netdev - Re: [PATCH v4 1/5] net: Introduce new feature setting ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120124190513.GC19993@rere.qmqm.pl>
Date:	Tue, 24 Jan 2012 20:05:13 +0100
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v4 1/5] net: Introduce new feature setting ops

On Tue, Jan 24, 2012 at 03:30:02PM +0000, Ben Hutchings wrote:
> On Tue, 2012-01-24 at 14:54 +0100, Eric Dumazet wrote:
> > Le lundi 07 février 2011 à 19:39 +0000, Ben Hutchings a écrit :
> > > On Thu, 2011-02-03 at 15:21 +0100, Michał Mirosław wrote:
> > > > This introduces a new framework to handle device features setting.
> > > > It consists of:
> > > >   - new fields in struct net_device:
> > > > 	+ hw_features - features that hw/driver supports toggling
> > > > 	+ wanted_features - features that user wants enabled, when possible
> > > >   - new netdev_ops:
> > > > 	+ feat = ndo_fix_features(dev, feat) - API checking constraints for
> > > > 		enabling features or their combinations
> > > > 	+ ndo_set_features(dev) - API updating hardware state to match
> > > > 		changed dev->features
> > > >   - new ethtool commands:
> > > > 	+ ETHTOOL_GFEATURES/ETHTOOL_SFEATURES: get/set dev->wanted_features
> > > > 		and trigger device reconfiguration if resulting dev->features
> > > > 		changed
> > > > 	+ ETHTOOL_GSTRINGS(ETH_SS_FEATURES): get feature bits names (meaning)
> > > > 
> > > > Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> > > Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>
> > Do we have any ethtool patch to use these 'new' features ?
> I have some unfinished changes to support this.  What I don't want to do
> is to add an entirely separate set of options; I want -k/-K to work with
> old and new kernel versions, supporting named features as an extension
> where available.

Ben, what are your patches like?  I mean their state?  I'm asking, because I
found a bit of time and rebased my earlier patch to current ethtool 3.2
this weekend.  Haven't sent them yet, because I'm seeing -EOPNOTSUPP from
kernel on x86_64 for GFEATURES and I'm trying to figure out where's the bug.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html