netdev - Re: [net PATCH 1/1] qlge:Changing netdev msg level to default debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120124.153837.905415925299369179.davem@davemloft.net>
Date:	Tue, 24 Jan 2012 15:38:37 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jitendra.kalsaria@...gic.com
Cc:	netdev@...r.kernel.org, ron.mercer@...gic.com,
	Dept_NX_Linux_NIC_Driver@...gic.com
Subject: Re: [net PATCH 1/1] qlge:Changing netdev msg level to default debug

From: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
Date: Mon, 23 Jan 2012 15:38:52 -0800

> Driver was passing -1 so that custom default get used but which
> makes it even more sane than 15 which was excessively verbose
> printing an unusual amount of messages.
> 
> Signed-off-by: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>

Please don't move this code away from the canonical way in which
default message levels are handled.

The canonical way is to specify a module param that starts with the
value "-1" which when passed as the first argument to netif_msg_init()
means "use the default mask" which is the second argument.

Moving to a default of "3" makes no sense at all, express the default
in the second argument of netif_msg_init(), not the first.

I'm not applying this patch, use other drivers such as tg3.c as a
guide.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html