netdev - Re: [PATCH net-next] net: flow_dissector.c missing include linux/export.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP=VYLpGk5+626QT31-nUkSJjay6ZnY8APxLfD-MUkqCJMxYng@mail.gmail.com>
Date:	Tue, 24 Jan 2012 15:59:00 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, jdb@...x.dk, netdev@...r.kernel.org,
	sfr@...b.auug.org.au
Subject: Re: [PATCH net-next] net: flow_dissector.c missing include linux/export.h

On Tue, Jan 24, 2012 at 3:51 PM, David Miller <davem@...emloft.net> wrote:
> From: Paul Gortmaker <paul.gortmaker@...driver.com>
> Date: Tue, 24 Jan 2012 14:44:21 -0500
>
>> On Tue, Jan 24, 2012 at 11:15 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>>> Le mardi 24 janvier 2012 à 16:57 +0100, Jesper Dangaard Brouer a écrit :
>>>> The file net/core/flow_dissector.c seems to be missing
>>>> including linux/export.h.
>>>>
>>>> Signed-off-by: Jesper Dangaard Brouer <hawk@...x.dk>
>>>> ---
>>>>  net/core/flow_dissector.c |    1 +
>>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
>>>> index 0985b9b..a225089 100644
>>>> --- a/net/core/flow_dissector.c
>>>> +++ b/net/core/flow_dissector.c
>>>> @@ -1,4 +1,5 @@
>>>>  #include <linux/skbuff.h>
>>>> +#include <linux/export.h>
>>>>  #include <linux/ip.h>
>>>>  #include <linux/ipv6.h>
>>>>  #include <linux/if_vlan.h>
>>>
>>>
>>> Acked-by: Eric Dumazet <eric.dumazet@...il.com>
>>>
>>> Hmm, not sure how you found this, since export.h is included from
>>> linux/netdevice.h (via net/netprio_cgroup.h & linux/module.h)
>>>
>>> Or maybe you want to remove linux/module.h inclusion from
>>> net/netprio_cgroup.h ???
>>
>> That would be the better solution.  I had them all killed off and it
>> would be nice to try and keep it that way as long as possible.
>>
>> I'll look into this if that wasn't part of Jesper's original intention.
>
> Jesper did you actually hit this problem and get a real build
> failure?

I've reproduced it locally, and verified it as a fix, but only *after*
I've deleted the module.h from netprio_cgroup.h

Doing builds to see what else (aside from the dsa/mv88e6xxx)
shakes loose.  Hopefully that is it.  If so, I'll send a patch
shortly to delete the module.h

Paul.

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html