netdev - Re: [PATCH] ipip: Fix bug added to ipip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327447295.14373.3.camel@edumazet-laptop>
Date:	Wed, 25 Jan 2012 00:21:35 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipip: Fix bug added to ipip_tunnel_xmit().

Le mardi 24 janvier 2012 à 18:18 -0500, David Miller a écrit :
> We can remove the rt_gateway == 0 check but we shouldn't
> remove the 'dst' initialization too.
> 
> Noticed by Eric Dumazet.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  net/ipv4/ipip.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c
> index 87c63b6..f84ebff 100644
> --- a/net/ipv4/ipip.c
> +++ b/net/ipv4/ipip.c
> @@ -454,6 +454,7 @@ static netdev_tx_t ipip_tunnel_xmit(struct sk_buff *skb, struct net_device *dev)
>  			dev->stats.tx_fifo_errors++;
>  			goto tx_error;
>  		}
> +		dst = rt->rt_gateway;
>  	}
>  
>  	rt = ip_route_output_ports(dev_net(dev), &fl4, NULL,


Well, a similar fix is needed for net/ipv4/ip_gre.c :)

(Its a bit late here, time for a sleep for me)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html