netdev - Re: [patch -next] bnx2x: unlock before returning an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327479294.11041.3.camel@lb-tlvb-dmitry>
Date:	Wed, 25 Jan 2012 10:14:54 +0200
From:	"Dmitry Kravkov" <dmitry@...adcom.com>
To:	"Dan Carpenter" <dan.carpenter@...cle.com>
cc:	"Eilon Greenstein" <eilong@...adcom.com>,
	"Yuval Mintz" <yuvalmin@...adcom.com>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch -next] bnx2x: unlock before returning an error

On Wed, 2012-01-25 at 10:59 +0300, Dan Carpenter wrote:
> We introduced a new return here but forgot to drop the lock.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> index cb6339c..69465c3 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> @@ -1836,6 +1836,7 @@ static int bnx2x_vlan_mac_del_all(struct bnx2x *bp,
>  			rc = exeq->remove(bp, exeq->owner, exeq_pos);
>  			if (rc) {
>  				BNX2X_ERR("Failed to remove command\n");
> +				spin_unlock_bh(&exeq->lock);
>  				return rc;
>  			}
>  			list_del(&exeq_pos->link);
> --

Thank you, Dan.

Acked-by: Dmitry Kravkov <dmitry@...adcom.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html