netdev - Re: [patch v4, kernel version 3.2.1] Source mode for macvlan interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsizzLp11qzJGTYr+m49yi=2RyWTjkOzaT7d3ni0EfvPsKmHg@mail.gmail.com>
Date:	Thu, 26 Jan 2012 12:04:50 +0100
From:	Štefan Gula <steweg@...t.sk>
To:	David Miller <davem@...emloft.net>
Cc:	kaber@...sh.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch v4, kernel version 3.2.1] Source mode for macvlan interface

2012/1/26 David Miller <davem@...emloft.net>:
> From: Stefan Gula <steweg@...t.sk>
> Date: Wed, 25 Jan 2012 09:48:54 +0100 (CET)
>
>> +             if (vlan->mode == MACVLAN_MODE_SOURCE &&
>> +                     vlan->mode != nla_get_u32(data[IFLA_MACVLAN_MODE]))
>  ...
>> +     if (data && data[IFLA_MACVLAN_MACADDR_MODE] &&
>> +             data[IFLA_MACVLAN_MACADDR]) {
>  ...
>> +                             return macvlan_hash_add_sources(vlan,
>> +                                     nla_data(data[IFLA_MACVLAN_MACADDR]));
>  ...
>> +                     hlist_for_each_entry_rcu(list, n,
>> +                             &vlan->port->vlan_source_hash[i], hlist) {
>  ...
>> +                     hlist_for_each_entry_rcu(list, n,
>> +                             &vlan->port->vlan_source_hash[i], hlist) {
>
> Line things up on subsequent lines to the column right after the
> openning parenthesis on the previous line.
>
> If things are indented too deeply, you need to write helper functions.
Just to be sure, how many "\t" symbols are ok in patches? I want to
avoid similar thing in future.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html