netdev - Re: [PATCH net-next] be2net: allocate more headroom in incoming skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120126.135151.240209789181199723.davem@davemloft.net>
Date:	Thu, 26 Jan 2012 13:51:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, Ian.Campbell@...rix.com,
	vasundhara.volam@...lex.com, sathya.perla@...lex.com,
	ajit.khaparde@...lex.com
Subject: Re: [PATCH net-next] be2net: allocate more headroom in incoming
 skbs

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 25 Jan 2012 14:56:30 +0100

> Allocation of 64 bytes in skb headroom is not enough if we have to pull
> ethernet + ipv6 + tcp headers, and/or extra tunneling header.
> 
> Its currently not noticed because netdev_alloc_skb_ip_align(64) give us
> more room, thanks to power-of-two kmalloc() roundups.
> 
> Make sure we ask for 128 bytes so that side effects of upcoming patches
> from Ian Campbell dont decrease benet rx performance, because of extra
> skb head reallocations.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html