netdev - Re: [PATCH 1/2] ipv4/ipv6: Prepare for new route gateway semantics.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F21C482.4070707@linux-ipv6.org>
Date:	Fri, 27 Jan 2012 06:24:18 +0900
From:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] ipv4/ipv6: Prepare for new route gateway semantics.

Hello.

David Miller wrote:
>
> In the future the ipv4/ipv6 route gateway will take on two types
> of values:
>
> 1) INADDR_ANY/IN6ADDR_ANY, for local network routes, and in this case
>     the neighbour must be obtained using the destination address in
>     ipv4/ipv6 header as the lookup key.
>
> 2) Everything else, the actual nexthop route address.
>
> So if the gateway is not inaddr-any we use it, otherwise we must use
> the packet's destination address.
>
> Signed-off-by: David S. Miller<davem@...emloft.net>
> ---
>   net/ipv4/route.c |    5 +++++
>   net/ipv6/route.c |   16 +++++++++++++++-
>   2 files changed, 20 insertions(+), 1 deletions(-)
>
:
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 8c2e3ab..7d7f306 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -121,9 +121,23 @@ static u32 *ipv6_cow_metrics(struct dst_entry *dst, unsigned long old)
>   	return p;
>   }
>
> +static inline const void *choose_neigh_daddr(struct rt6_info *rt, const void *daddr)
> +{
> +	struct in6_addr *p =&rt->rt6i_gateway;
> +
> +	if (p->s6_addr32[0] | p->s6_addr32[1] |
> +	    p->s6_addr32[2] | p->s6_addr32[3])
> +		return (const void *) p;
> +	return daddr;
> +}
> +

Why not use ipv6_addr_any()?

--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html