netdev - Re: [PATCH net V4 0/2] igb: ptp hardware clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327661789.2729.57.camel@jtkirshe-mobl>
Date:	Fri, 27 Jan 2012 02:56:29 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Richard Cochran <richardcochran@...il.com>,
	"Brown, Aaron F" <aaron.f.brown@...el.com>, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net,
	Jacob Keller <jacob.e.keller@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH net V4 0/2] igb: ptp hardware clock

On Fri, 2012-01-27 at 11:22 +0100, Eric Dumazet wrote:
> Le vendredi 27 janvier 2012 à 02:15 -0800, Jeff Kirsher a écrit :
> > On Fri, 2012-01-27 at 11:11 +0100, Richard Cochran wrote:
> > > On Thu, Jan 26, 2012 at 08:24:53PM -0800, Jeff Kirsher wrote:
> > > > Richard-
> > > > 
> > > > Did you compile test?  Why I ask is our validation team is getting the
> > > > following errors when trying to compile in PTP support:
> > > 
> > > I did compile and also tested the driver.
> > > 
> > > What .config are you using? What kernel version?
> > > 
> > > Thanks,
> > > Richard
> > 
> > I will have Aaron post his .config's that he tried.  I know that he
> > tried multiple configs with no success.  As far as kernel version, he
> > was using the latest net-next tree from David Miller.
> 
> This might coming from
> 
> commit 36a1211970193ce215de50ed1e4e1272bc814df1
> Author: Paul Gortmaker <paul.gortmaker@...driver.com>
> Date:   Tue Jan 24 11:33:19 2012 +0000
> 
>     netprio_cgroup.h: dont include module.h from other includes
>     
>     A considerable effort was invested in wiping out module.h
>     from being present in all the other standard includes.  This
>     one leaked back in, but once again isn't strictly necessary,
>     so remove it.
>     
> 
> 

Eric was correct.  I added #include <linux/mdoule.h> to the igb_ptp.c
file and the error goes away.

Richard are you fine with me adding that change to your first patch of
the series?  That way I can have the validation team finish up testing
your patches.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)