lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Jan 2012 13:01:06 -0800 From: Joe Perches <joe@...ches.com> To: Ben Hutchings <bhutchings@...arflare.com> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, linux-net-drivers@...arflare.com Subject: Re: [PATCH net-next 03/32] sfc: Remove parentheses around return expressions, reported by checkpatch On Fri, 2012-01-27 at 20:42 +0000, Ben Hutchings wrote: > Fix the following error: > ERROR: return is not a function, parentheses are not required > Signed-off-by: Ben Hutchings <bhutchings@...arflare.com> trivia: > diff --git a/drivers/net/ethernet/sfc/rx.c b/drivers/net/ethernet/sfc/rx.c [] > @@ -98,8 +98,8 @@ static inline unsigned int efx_rx_buf_offset(struct efx_nic *efx, > /* Offset is always within one page, so we don't need to consider > * the page order. > */ > - return (((__force unsigned long) buf->dma_addr & (PAGE_SIZE - 1)) + > - efx->type->rx_buffer_hash_size); > + return ((__force unsigned long) buf->dma_addr & (PAGE_SIZE - 1)) + > + efx->type->rx_buffer_hash_size; > } The function returns unsigned int, perhaps the cast should be (__force unsigned int) or the function should return unsigned long or maybe size_t? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists