netdev - Re: [PATCH net V4 0/2] igb: ptp hardware clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327638293.2729.43.camel@jtkirshe-mobl>
Date:	Thu, 26 Jan 2012 20:24:53 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Richard Cochran <richardcochran@...il.com>,
	"Brown, Aaron F" <aaron.f.brown@...el.com>
Cc:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	Jacob Keller <jacob.e.keller@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH net V4 0/2] igb: ptp hardware clock

On Sat, 2012-01-21 at 17:03 +0100, Richard Cochran wrote:
> * ChangeLog
> ** V4
>    - Use standard kernel cyclecounter/timecounter infrastructure
>      instead of a home grown counter overflow implementation.
> ** V3
>    - Driver compiles even without CONFIG_PTP_1588_CLOCK.
>    - Timestamping always works, even when PTP code missing or fails.
> ** V2
>    - Fixed wrong bit shifting in the 82576 code.
>    - Explained the timestamp locking with a comment in the code.
>    - Preserved the comments from the original timecompare implementation.
>    - Added an additional test within the overflow counter code to fix
>      a race condition. Details of the problem are given in the commit
>      message.
> 
> This patch series implements a PHC driver for the Intel 82576 and
> 82580 devices, as part of the igb driver.  Only the base clock
> operations are implemented. The hardware does have some ancillary
> features, but these can be easily added later.
> 
> The first patch adds the PHC driver code as a new source module but
> does not link it into the main igb driver. Because the system time
> counter is not so very wide, the code uses the overflow counter from
> the cyclecounter/timecounter code. Every read operation maintains the
> overflow counter, as does a "delayed work" watchdog. 
> 
> The second patch removes the timecompare code and links in the new
> functions.
> 
> I have tested the 82580 with good results. However, I don't have the
> 82576 and so would appreciate testing and feedback.
> 
> Thanks,
> Richard
> 
> 
> Richard Cochran (2):
>   igb: add PTP Hardware Clock code
>   igb: offer a PTP Hardware Clock instead of the timecompare method
> 
>  drivers/net/ethernet/intel/igb/Makefile   |    2 +-
>  drivers/net/ethernet/intel/igb/igb.h      |   20 ++-
>  drivers/net/ethernet/intel/igb/igb_main.c |  167 +------------
>  drivers/net/ethernet/intel/igb/igb_ptp.c  |  388 +++++++++++++++++++++++++++++
>  4 files changed, 407 insertions(+), 170 deletions(-)
>  create mode 100644 drivers/net/ethernet/intel/igb/igb_ptp.c
> 

Added Aaron Brown to the thread

Richard-

Did you compile test?  Why I ask is our validation team is getting the
following errors when trying to compile in PTP support:

---------------------------
drivers/net/ethernet/intel/igb/igb_ptp.c: In function âigb_ptp_initâ:
drivers/net/ethernet/intel/igb/igb_ptp.c:266: error: âTHIS_MODULEâ undeclared (first use in this function)
drivers/net/ethernet/intel/igb/igb_ptp.c:266: error: (Each undeclared identifier is reported only once
drivers/net/ethernet/intel/igb/igb_ptp.c:266: error: for each function it appears in.)
make[5]: *** [drivers/net/ethernet/intel/igb/igb_ptp.o] Error 1
make[4]: *** [drivers/net/ethernet/intel/igb] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [drivers/net/ethernet/intel] Error 2
make[2]: *** [drivers/net/ethernet] Error 2
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
-------------------------------

Cheers,
Jeff

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)