netdev - Re: [PATCH] net/tcp: Fix tcp memory limits initialization when !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120130.124153.637018079987753669.davem@davemloft.net>
Date:	Mon, 30 Jan 2012 12:41:53 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	glommer@...allels.com
Cc:	netdev@...r.kernel.org, mingo@...e.hu
Subject: Re: [PATCH] net/tcp: Fix tcp memory limits initialization when
 !CONFIG_SYSCTL

From: Glauber Costa <glommer@...allels.com>
Date: Mon, 30 Jan 2012 15:20:17 +0400

> sysctl_tcp_mem() initialization was moved to sysctl_tcp_ipv4.c
> in commit 3dc43e3e4d0b52197d3205214fe8f162f9e0c334, since it
> became a per-ns value.
> 
> That code, however, will never run when CONFIG_SYSCTL is
> disabled, leading to bogus values on those fields - causing hung
> TCP sockets.
> 
> This patch fixes it by keeping an initialization code in
> tcp_init(). It will be overwritten by the first net namespace
> init if CONFIG_SYSCTL is compiled in, and do the right thing if
> it is compiled out.
> 
> It is also named properly as tcp_init_mem(), to properly signal
> its non-sysctl side effect on TCP limits.
> 
> Reported-by: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Glauber Costa <glommer@...allels.com>
> Cc: David S. Miller <davem@...emloft.net>
> Link: http://lkml.kernel.org/r/4F22D05A.8030604@parallels.com
> [ renamed the function, tidied up the changelog a bit ]
> Signed-off-by: Ingo Molnar <mingo@...e.hu>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html