netdev - Re: [PATCH 2/2] IB/ipoib: fix GRO merge failure for IPoIB originated TCP streams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL1RGDXjjQ-PhCv-9WJX45NuovC9XiS=_7507OsyvLW_gBaJ5g@mail.gmail.com>
Date:	Mon, 30 Jan 2012 10:11:18 -0800
From:	Roland Dreier <roland@...nel.org>
To:	Shlomo Pongratz <shlomop@...lanox.com>
Cc:	Or Gerlitz <ogerlitz@...lanox.com>,
	linux-rdma <linux-rdma@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/2] IB/ipoib: fix GRO merge failure for IPoIB originated
 TCP streams

On Sun, Jan 29, 2012 at 11:44 PM, Shlomo Pongratz <shlomop@...lanox.com> wrote:
> I see this fix as part of a more general fix, one that will enable more protocols (e.g. X25, PPP) to enjoy the benefit of GRO.
> I think that the more general fix should include adding a MAC comparison function to the header_ops structure in netdev.h.
> Then network drivers which are not Ethernet will register their own comparison function, and the GRO code will check if such routine exists and if so will use it.
> The problem with this approach is that until such a major fix is integrated the IPoIB performance will suffer.
> This simple fix will enable us to use the benefit of GRO until the more general fix is integrated.

But is this general fix so difficult that we can't just do the right thing?

Realistically if we add this hack to ipoib then we'll have that ugly
memset in our fast path forever.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html