lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jan 2012 23:09:32 +0000 From: Ben Hutchings <bhutchings@...arflare.com> To: Danny Kukawka <danny.kukawka@...ect.de> CC: Armin Schindler <mac@...ware.de>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, Karsten Keil <isdn@...ux-pingi.de> Subject: Re: [PATCH 01/16] eicon: fix -Warray-bounds warning On Mon, 2012-01-30 at 23:00 +0100, Danny Kukawka wrote: > Fix for a -Warray-bounds warning. mixer_notify_update() tries to > write to ((CAPI_MSG *) msg)->info.facility_req.structs[3] while > structs is defined as byte structs[1], define structs[1] as > structs[4]. I suspect that all the 'byte structs[1];' fields defined in that header are actually variable-length arrays. In that case, there may be no reasonable bound you can specify. Ben. > Signed-off-by: Danny Kukawka <danny.kukawka@...ect.de> > --- > drivers/isdn/hardware/eicon/capi20.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/isdn/hardware/eicon/capi20.h b/drivers/isdn/hardware/eicon/capi20.h > index 7ebcccd..f9170ad 100644 > --- a/drivers/isdn/hardware/eicon/capi20.h > +++ b/drivers/isdn/hardware/eicon/capi20.h > @@ -226,7 +226,7 @@ typedef struct { > /* FACILITY-REQUEST */ > typedef struct { > word Selector; > - byte structs[1]; /* Facility parameters */ > + byte structs[4]; /* Facility parameters */ > } _FAC_REQP; > /* FACILITY-CONFIRM STRUCT FOR SUPPLEMENT. SERVICES */ > typedef struct { -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists