netdev - Re: [PATCH 1/1] wireless: in _rtl92c_phy_calculate_bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F272992.9000502@lwfinger.net>
Date:	Mon, 30 Jan 2012 17:36:50 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	"Devendra.Naga" <devendra.aaru@...il.com>
CC:	chaoming_li@...lsil.com.cn, linville@...driver.com,
	paul.gortmaker@...driver.com, joe@...ches.com,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] wireless: in _rtl92c_phy_calculate_bit_shift remove
 comparing bitmask against 1

On 01/30/2012 04:00 AM, Devendra.Naga wrote:
> From: "Devendra.Naga"<devendra.aaru@...il.com>
>
> in _rtl92c_phy_calculate_bit_shift everytime the right shifted bitmask
> is AND with 1 and compared against 1. i.e.
>          if ((bitmask>>  i)&  0x1 == 1)
>                  break;
> which in the if condition is anyway becomes a 1 or 0.
>
> Signed-off-by: Devendra.Naga<devendra.aaru@...il.com>

Once again, the patch is OK, but the subject is not good.

Larry

> ---
>   drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
> index 22e998d..a76b223 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
> @@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask)
>   	u32 i;
>
>   	for (i = 0; i<= 31; i++) {
> -		if (((bitmask>>  i)&  0x1) == 1)
> +		if ((bitmask>>  i)&  0x1)
>   			break;
>   	}
>   	return i;

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html