lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jan 2012 17:51:36 +0800 From: Shawn Guo <shawn.guo@...aro.org> To: Richard Zhao <richard.zhao@...aro.org> Cc: netdev@...r.kernel.org, davem@...emloft.net, u.kleine-koenig@...gutronix.de, LW@...O-electronics.de, linux-arm-kernel@...ts.infradead.org, patches@...aro.org Subject: Re: [PATCH 1/1] net: fec: correct phy_name buffer length when init phy_name On Mon, Jan 30, 2012 at 04:08:12PM +0800, Richard Zhao wrote: > Fix the bug that we got wrong phy_name on imx6q sabrelite board. > snprintf used wrong length of phy_name. > phy_name length is MII_BUS_ID_SIZE + 3 rather not MII_BUS_ID_SIZE. > I change it to sizeof(phy_name). > > Signed-off-by: Richard Zhao <richard.zhao@...aro.org> Acked-by: Shawn Guo <shawn.guo@...aro.org> Since this patch fixes a regression seen on v3.3-rc1, it may be suitable for -rc series. The offending commit for the regression would be 391420f (fec: use an unique MDIO bus name.) which increases the string length of fep->mii_bus->id consequently mdio_bus_id. Regards, Shawn > --- > drivers/net/ethernet/freescale/fec.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c > index 7b25e9c..1c7aad8 100644 > --- a/drivers/net/ethernet/freescale/fec.c > +++ b/drivers/net/ethernet/freescale/fec.c > @@ -990,7 +990,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) > phy_id = 0; > } > > - snprintf(phy_name, MII_BUS_ID_SIZE, PHY_ID_FMT, mdio_bus_id, phy_id); > + snprintf(phy_name, sizeof(phy_name), PHY_ID_FMT, mdio_bus_id, phy_id); > phy_dev = phy_connect(ndev, phy_name, &fec_enet_adjust_link, 0, > fep->phy_interface); > if (IS_ERR(phy_dev)) { > -- > 1.7.5.4 > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists