netdev - Re: Sundance network driver (D-Link DFE-580TX) timeouts rendering interface unusable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327918447.2288.24.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Mon, 30 Jan 2012 11:14:07 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Denis Kirjanov <kirjanov@...il.com>
Cc:	Ben Hutchings <ben@...adent.org.uk>,
	"Mike ." <mike-bugreport@...mail.com>, 656476@...s.debian.org,
	netdev <netdev@...r.kernel.org>
Subject: Re: Sundance network driver (D-Link DFE-580TX) timeouts rendering
 interface unusable

Le lundi 30 janvier 2012 à 12:51 +0300, Denis Kirjanov a écrit :
> I'll check this out. After kernel.org was cracked I've missed
> @kernel.org mail account.


At first glance, start_tx() is racy against TX completion.

It does :

        if (np->cur_tx - np->dirty_tx < TX_QUEUE_LEN - 1 &&
            !netif_queue_stopped(dev)) {
                /* do nothing */
        } else {
                netif_stop_queue (dev);
        }

So it can call netif_stop_queue() while TX completion handler did a
cleanup of all queued packets right before.


Note intr_handler() doesnt hold the queue spinlock when it does :

                if (netif_queue_stopped(dev) &&
                        np->cur_tx - np->dirty_tx < TX_QUEUE_LEN - 4) {
                        /* The ring is no longer full, clear busy flag. */
                        netif_wake_queue (dev);
                }


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html