netdev - RE: [07/22] Cyclades PC300 driver: ioctl() fixes for mixed 64/32-bit systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1327934267.5400.445.camel@deadeye>
Date:	Mon, 30 Jan 2012 14:37:47 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Laight <David.Laight@...LAB.COM>
CC:	Andrea Shepard <andrea@...sephoneslair.org>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<khc@...waw.pl>, <davem@...emloft.net>, <mmarek@...e.cz>,
	<jkosina@...e.cz>, <joe@...ches.com>, <justinmattock@...il.com>,
	<gregkh@...e.de>, <alan@...ux.intel.com>, <jdmason@...zu.us>
Subject: RE: [07/22] Cyclades PC300 driver: ioctl() fixes for mixed
 64/32-bit systems

On Mon, 2012-01-30 at 11:44 +0000, David Laight wrote:
> > +struct pc300_net_stats {
> > +	u64 rx_packets;
> ...
> > +	u64 rx_compressed;
> > +	u64 tx_compressed;
> > +};
> > +
> >  typedef struct pc300stats {
> >  	int hw_type;
> >  	u32 line_on;
> >  	u32 line_off;
> > -	struct net_device_stats gen_stats;
> > +	/* Use this instead of net_device_stats, since passing
> > +	 * net_device_stats breaks 32-bit user processes on 
> > 64-bit kernels,
> > +	 * and rtnetlink is unreasonably complicated just to get
> > +	 * some statistics.
> > +	 */
> > +	struct pc300_net_stats net_stats;
> >  	falc_t te_stats;
> >  } pc300stats_t;
> 
> Since 'struct net_device_stats' looks like a common structure,
> maybe the 64bit version should be added in the same place??
[...]

It's called struct rtnl_link_stats64 and is already defined in
<linux/rtnetlink.h> (where it must remain).

This change doesn't seem to be a proper fix.  If the ioctl interface to
this driver uses struct net_device_stats (which I didn't realise,
otherwise I would have left that structure exported from
<linux/netdevice.h>) then it should continue doing so to maintain
compatibility.  The driver will have to fix up the outgoing structure
with the aid of is_compat_task().

If backward-compatibility is really not a concern for the driver then
this ioctl should be completely removed in favour of ethtool extended
stats.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html