netdev - Re: [PATCH net-next] ipv6: fix RFC5722 comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jan 2012 15:42:25 +0100
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] ipv6: fix RFC5722 comment

Le 30/01/2012 15:29, Eric Dumazet a écrit :
> RFC5722 Section 4 was amended by Errata 3089
>
> Our implementation did the right thing anyway...
>
> Signed-off-by: Eric Dumazet<eric.dumazet@...il.com>
> Cc: Nicolas Dichtel<nicolas.dichtel@...nd.com>

Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> ---
>   net/ipv6/reassembly.c |    7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c
> index b69fae7..9447bd6 100644
> --- a/net/ipv6/reassembly.c
> +++ b/net/ipv6/reassembly.c
> @@ -336,12 +336,11 @@ static int ip6_frag_queue(struct frag_queue *fq, struct sk_buff *skb,
>   	}
>
>   found:
> -	/* RFC5722, Section 4:
> -	 *                                  When reassembling an IPv6 datagram, if
> +	/* RFC5722, Section 4, amended by Errata ID : 3089
> +	 *                          When reassembling an IPv6 datagram, if
Identation was an exact copy of the original rfc (not changed by the errata), 
but it's a detail ;-)


Regards,
Nicolas

>   	 *   one or more its constituent fragments is determined to be an
>   	 *   overlapping fragment, the entire datagram (and any constituent
> -	 *   fragments, including those not yet received) MUST be silently
> -	 *   discarded.
> +	 *   fragments) MUST be silently discarded.
>   	 */
>
>   	/* Check for overlap with preceding fragment. */
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html