netdev - Re: brcm80211 breakage..

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFy5-x6Zevga=rX_q+6vsmXFHyMJ+m8YqrqjC6yELqS6mw@mail.gmail.com>
Date:	Tue, 31 Jan 2012 09:02:38 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Henrik Rydberg <rydberg@...omail.se>,
	Arend van Spriel <arend@...adcom.com>,
	Franky Lin <frankyl@...adcom.com>
Cc:	"John W. Linville" <linville@...hat.com>,
	Network Development <netdev@...r.kernel.org>,
	Rafał Miłecki <zajec5@...il.com>
Subject: Re: brcm80211 breakage..

On Tue, Jan 31, 2012 at 4:08 AM, Henrik Rydberg <rydberg@...omail.se> wrote:
>
> probing simply fails on my machine,
>
> [  882.064120] bcma: Failed to get SPROM: -71
> [  882.064256] bcma-pci-bridge: probe of 0000:01:00.0 failed with error -2
>
> resulting in no wireless. Since the bcma SPROM setup allegedly is
> unused, simply ignoring the error with this hack

I personally hit the "No SPROM available" case, which is apparently
why it works for me.

That said, I obviously agree with your patch: if we don't fail for the
"No SPROM available" case, then we damn well shouldn't fail just
because it *is* available but we can't read it or whatever.

So Ack on the patch from me, but it should go through the network
guys. Arend, John?

                         Linus

> diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
> index febbc0a..cb69fb0 100644
> --- a/drivers/bcma/main.c
> +++ b/drivers/bcma/main.c
> @@ -171,7 +171,6 @@ int bcma_bus_register(struct bcma_bus *bus)
>                pr_err("No SPROM available\n");
>        } else if (err) {
>                pr_err("Failed to get SPROM: %d\n", err);
> -               return -ENOENT;
>        }
>
>        /* Register found cores */
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html