netdev - RE: [PATCH] bna: Implement ethtool flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B5EE62D80D50B84BB9E5174F7FCCE80A260325B6E1@HQ1-EXCH02.corp.brocade.com>
Date:	Wed, 1 Feb 2012 14:10:32 -0800
From:	Krishna Gudipati <kgudipat@...cade.com>
To:	"'Ben Hutchings'" <bhutchings@...arflare.com>
CC:	"'davem@...emloft.net'" <davem@...emloft.net>,
	"'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
	Adapter Linux Open SRC Team 
	<adapter_linux_open_src_team@...cade.COM>
Subject: RE: [PATCH] bna: Implement ethtool flash_device entry point.

Thanks Ben for the review.

I am making the changes as per the review comments to return proper error code.

> +	init_completion(&fcomp.comp);
> +	spin_lock_irqsave(&bnad->bna_lock, flags);

No need to save flags, this is not called in IRQ context!

[Krishna]: bna_lock is used in Interrupt context as well, by using spin_lock_irq instead of
	     spin_lock_irqsave() - we will lose the state of the interrupts & will
	     unconditionally enable interrupts. We plan to stay with using spin_lock_irqsave()
	     as it's safe.

Thanks,
Krishna.