netdev - Re: [PATCH 2/2] IB/ipoib: fix GRO merge failure for IPoIB originated TCP streams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZJVAQoy0B30zqkROOBp_-bF6=EdU2L9V025fJgTexVuFQ@mail.gmail.com>
Date:	Wed, 1 Feb 2012 11:43:23 +0200
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>,
	Roland Dreier <roland@...nel.org>
Cc:	Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org,
	linux-rdma <linux-rdma@...r.kernel.org>,
	Shlomo Pongratz <shlomop@...lanox.com>
Subject: Re: [PATCH 2/2] IB/ipoib: fix GRO merge failure for IPoIB originated
 TCP streams

On Wed, Feb 1, 2012 at 10:38 AM, Herbert Xu <herbert@...dor.apana.org.au> wrote:
> On Wed, Feb 01, 2012 at 10:23:22AM +0200, Or Gerlitz wrote:

>> So what would you recommend here? not sure if you saw that, but Shlomo
>> suggested to add new entry to the header ops, compare_header e.g such
>> that if skb->dev has this callback use it instead of
>> compare_ether_header in __napi_gro_receive, makes sense?

> If we just turn it into a memcmp with a variable length would
> that work for you?

I think yes, FWIW we will compare the IPoIB header, Roland is that okay for you?

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html