netdev - Re: [PATCH] Implement IP_UNICAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120201.141232.458020616314562146.davem@davemloft.net>
Date:	Wed, 01 Feb 2012 14:12:32 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ehoover@...es.edu
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Implement IP_UNICAST_IF socket option.

From: "Erich E. Hoover" <ehoover@...es.edu>
Date: Thu, 26 Jan 2012 16:57:48 -0700

> The IP_UNICAST_IF feature is needed by the Wine project.  This patch
> implements the feature by setting the outgoing interface in the same
> fashion as that of IP_PKTINFO.
> 
> Signed-off-by: Erich E. Hoover <ehoover@...es.edu>

Hmmm, this is not how IP_UNICAST_IF is implemented in other systems.

The passed in argument is always a 32-bit network byte order word, and
it is always interpreted as an interface index only.  There are no
provisions for specifying an IPV4 address.

I see no value in exporting a different API than what other systems
use, especially if you are adding this interface exactly for providing
support for WINE applications, so please don't do this thing with
argument sizes and ip_mreqn.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html