netdev - Re: [PATCH net-next] net: dev: Convert printks to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120201.142156.871464551711177387.davem@davemloft.net>
Date:	Wed, 01 Feb 2012 14:21:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dev: Convert printks to pr_<level>

From: Joe Perches <joe@...ches.com>
Date: Sun, 29 Jan 2012 16:20:30 -0800

> -		pr_warning("Number of in use tx queues changed "
> -			   "invalidating tc mappings. Priority "
> -			   "traffic classification disabled!\n");
> +		pr_warn(
> +"Number of in use tx queues changed invalidating tc mappings. "
> +"Priority traffic classification disabled!\n");

Don't do things like this.  It is never correct to un-indent subsequent
lines of a string like this.  And a line ending in "pr_whatever(" looks
terrible.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html