[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20120201.142805.256231314680157196.davem@davemloft.net>
Date: Wed, 01 Feb 2012 14:28:05 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: weiyj.lk@...il.com
Cc: haiyangz@...rosoft.com, kys@...rosoft.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net/hyperv: fix the issue that large packets be
dropped by bridge
From: Wei Yongjun <weiyj.lk@...il.com>
Date: Mon, 30 Jan 2012 16:12:45 +0800
> + /*
> + * Make sure we got a valid packet message, now total_data_buflen
> + * should be the data packet size plus the trailer padding size
> + */
> + if (pkt->total_data_buflen < rndis_pkt->data_len) {
> + netdev_err(dev->net_dev->ndev, "incoming packet message "
> + "buffer overflow detected (got %u, min %u)"
> + "...dropping this message!\n",
> + pkt->total_data_buflen, rndis_pkt->data_len);
> + return;
> + }
This is inappropriate. Any logging message that is potentially remotely
triggerable must at a minimum be rate limited. But to be honest I'd
much prefer a statistic counter for this kind of event, rather then
a log message.
I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists