lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 2 Feb 2012 20:01:52 +0100
From:	Karsten Keil <kkeil@...ux-pingi.de>
To:	geunsik.lim@...il.com
Cc:	David Miller <davem@...emloft.net>, isdn@...ux-pingi.de,
	lucas.demarchi@...fusion.mobi, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Keep kernel coding style rule of hfs-s+/sp source

On Wed, Feb 01, 2012 at 02:48:43AM -0500, David Miller wrote:
> From: Geunsik Lim <geunsik.lim@...il.com>
> Date: Wed, 1 Feb 2012 16:45:09 +0900
> 
> > On Wed, Feb 1, 2012 at 4:06 PM, David Miller <davem@...emloft.net> wrote:
> > 
> >> From: Geunsik Lim <geunsik.lim@...il.com>
> >> Date: Wed,  1 Feb 2012 15:59:53 +0900
> >>
> >> > Modified for kernel coding style rule of hfs-s+/sp device driver .
> >> > . reference: ./Documentation/CodingStyle
> >> >
> >> > ex)
> >> > 60 Don't put multiple statements on a single line unless you have
> >> > 61 something to hide:
> >> > 62
> >> > 63         if (condition) do_this;
> >> > 64           do_something_everytime;
> >> >
> >> > Signed-off-by: Geunsik Lim <geunsik.lim@...sung.com>
> >>
> >> This was probably there to eliminate compiler warnings or avoid the

Yes it was.

> >>
> > Thank you for your opinion.
> > It's strange. I did not meet compiler warnings you replied.

I did not remember which version it was, it must been arround the time
when that code was developed. I did not like this method, but this was
at this time the suggested workaround from the GCC guys the problem is,
even when you read the value into a register, it makes no difference, you
cannot do anything with it.
I agree with David, such patches are not really needed, the danger that
something gets wrong is too high.
I think in this case a coding style violation is minor to a warning or
potencial miscompiling.
Do not misunderstand me that I do not like to make the code better and more
readable, but such small style violations should be only fixed when here is
a strong need or the driver is reworked in bigger parts and full testing
is done.

Best Regards

Karsten
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists