netdev - RE: [PATCH 2/2] IB/ipoib: fix GRO merge failure for IPoIB originated TCP streams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1828884A29C6694DAF28B7E6B8A823733349A6C9@ORSMSX101.amr.corp.intel.com>
Date:	Fri, 3 Feb 2012 20:24:00 +0000
From:	"Hefty, Sean" <sean.hefty@...el.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Or Gerlitz <ogerlitz@...lanox.com>,
	linux-rdma <linux-rdma@...r.kernel.org>,
	Shlomo Pongratz <shlomop@...lanox.com>,
	Roland Dreier <roland@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: RE: [PATCH 2/2] IB/ipoib: fix GRO merge failure for IPoIB
 originated TCP streams

> > > Hi Sean, this is the patch posted earlier by Eric enhanced to
> > > have IPoIB to set gro_mac_header_len to the ipoib header len, does
> > > it make things to work okay for you?
> >
> > I ran a quick test.  It helps some, but the performance for streaming
> packets in one direction is still only 0.11 Gbps.  It should be closer to 10-
> 15 Gbps for ipoib on my systems.
> >
> > - Sean
> 
> Hmm... a tcpdump would help to understand what is going on (for example
> if GRO kicks in)

I should stop trying to apply patches so late.  I must have done something wrong with my quick test.  Re-applying the patch on 3.2, the ipoib UD performance looks okay to me with Eric's patch.  Sorry about the flub.

- Sean