netdev - Re: Regulator support for smsc911x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Feb 2012 01:17:23 -0200
From:	Fabio Estevam <festevam@...il.com>
To:	robert.marklund@...ricsson.com
Cc:	netdev@...r.kernel.org, Sascha Hauer <kernel@...gutronix.de>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: Regulator support for smsc911x

On Thu, Feb 2, 2012 at 11:02 PM, Fabio Estevam <festevam@...il.com> wrote:
> Robert,
>
> Since commit c7e963f6 (net/smsc911x: Add regulator support) I am no
> longer able to use smsc911x driver due to the lack of regulators for
> smsc on mx31_3ds board.
>
> Do you a board example that uses such regulator, so that I can look
> for a reference?

Ok, I fixed it by enabling CONFIG_REGULATOR_DUMMY on
imx_v6_v7_defconfig, but I am wondering if the patch below would be a
more appropriate fix:

--- a/drivers/net/ethernet/smsc/Kconfig
+++ b/drivers/net/ethernet/smsc/Kconfig
@@ -102,6 +102,8 @@ config SMSC911X
        select NET_CORE
        select MII
        select PHYLIB
+       select REGULATOR
+       select REGULATOR_DUMMY
        ---help---
          Say Y here if you want support for SMSC LAN911x and LAN921x families
          of ethernet controllers.

Please advise if I should fix it in Kconfig or defconfig, so that I
can submit a patch.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html