netdev - RE: [PATCH] tcp: RST: binding oif to iif for tcp v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1328342816.2577.8.camel@edumazet-laptop>
Date:	Sat, 04 Feb 2012 09:06:56 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Shawn Lu <shawn.lu@...csson.com>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"xiaoclu@...il.com" <xiaoclu@...il.com>
Subject: RE: [PATCH] tcp: RST: binding oif to iif for tcp v4

Le vendredi 03 février 2012 à 16:43 -0500, Shawn Lu a écrit :

> [shawn Lu] ok.  Tcp socket is bind to device using SO_BINDTODEVICE  to
> Limit traffic to specifc interface.  Sometime, it may not have a valid
> Source address to get through ip_route_output_key. 
> 

Define "Sometime" ?

We have to force the oif only if requested by the socket in this case.

arg.bound_dev_if = sk ? sk->sk_bound_dev_if : 0;

Thats what we do in tcp_v4_send_ack() :
	if (oif)
		arg.bound_dev_if = oif;




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html