netdev - Re: [PATCH] arch: net: bpf_jit_comp: Fixed coding style issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120204.165122.841855829159259361.davem@davemloft.net>
Date:	Sat, 04 Feb 2012 16:51:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mbarekfiras@...il.com
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, x86@...nel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch: net: bpf_jit_comp: Fixed coding style issues.

From: Mbarek Firas <mbarekfiras@...il.com>
Date: Fri,  3 Feb 2012 01:38:15 +0100

> -			COND_SEL(BPF_S_JMP_JGT_K, X86_JA, X86_JBE);
> -			COND_SEL(BPF_S_JMP_JGE_K, X86_JAE, X86_JB);
> -			COND_SEL(BPF_S_JMP_JEQ_K, X86_JE, X86_JNE);
> -			COND_SEL(BPF_S_JMP_JSET_K,X86_JNE, X86_JE);
> -			COND_SEL(BPF_S_JMP_JGT_X, X86_JA, X86_JBE);
> -			COND_SEL(BPF_S_JMP_JGE_X, X86_JAE, X86_JB);
> -			COND_SEL(BPF_S_JMP_JEQ_X, X86_JE, X86_JNE);
> -			COND_SEL(BPF_S_JMP_JSET_X,X86_JNE, X86_JE);
> +			COND_SEL(BPF_S_JMP_JGT_K,  X86_JA,  X86_JBE);
> +			COND_SEL(BPF_S_JMP_JGE_K,  X86_JAE, X86_JB);
> +			COND_SEL(BPF_S_JMP_JEQ_K,  X86_JE,  X86_JNE);
> +			COND_SEL(BPF_S_JMP_JSET_K, X86_JNE, X86_JE);

This is rediculious, it's not fixing anything.

There is no requirement that all the arguments have to line up
to the same column on every line.

I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html