netdev - RE: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62162DF05402B341B3DB59932A1FA992B5B5C9FD01@EUSAACMS0702.eamcs.ericsson.se>
Date:	Sat, 4 Feb 2012 17:47:09 -0500
From:	Shawn Lu <shawn.lu@...csson.com>
To:	David Miller <davem@...emloft.net>
CC:	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"xiaoclu@...il.com" <xiaoclu@...il.com>
Subject: RE: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case

Hi,David:

I do appreciate Eric's helpand contribution in this fix. 
I am a newer here. I just don't know how I can give credit to him. I thought
That you will put "Acked-by: Eric Dumazet <eric.dumazet@...il.com>" to 
Credit his contribution.

Thanks!
Shawn Lu  

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net] 
> Sent: Saturday, February 04, 2012 1:47 PM
> To: Shawn Lu
> Cc: eric.dumazet@...il.com; netdev@...r.kernel.org; xiaoclu@...il.com
> Subject: Re: [PATCH] tcp_v4_send_reset: binding oif to iif in 
> no sock case
> 
> From: Shawn Lu <shawn.lu@...csson.com>
> Date: Sat, 4 Feb 2012 13:44:57 -0800
> 
> > Binding RST packet outgoing interface to incoming interface 
> for tcp v4 
> > when there is no socket associate with it.
> > This has few benefits:
> > 1. tcp_v6_send_reset already did that.
> > 2. This helps tcp connect with SO_BINDTODEVICE set. When 
> connection is 
> > lost, we still able to sending out RST using same interface.
> > 3. we are sending reply, it is most likely to be succeed if iif is 
> > used
> > 
> > Signed-off-by: Shawn Lu <shawn.lu@...csson.com>
> 
> Sigh...
> 
> Thanks for giving Eric not credit whatsoever for his 
> contributions and feedback for this fix. :-/
> --
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html