netdev - Re: [PATCH] net: move ethtool include to where its used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120205.002403.528386341681036443.davem@davemloft.net>
Date:	Sun, 05 Feb 2012 00:24:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	vapier@...too.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: move ethtool include to where its used

From: Mike Frysinger <vapier@...too.org>
Date: Sat, 4 Feb 2012 21:20:07 -0500

> On Saturday 04 February 2012 16:23:31 David Miller wrote:
>> From: Mike Frysinger <vapier@...too.org>
>> > The linux/mii.h headers has long been standalone for userspace.  But a
>> > recent commit added linux/ethtool.h to the include list even when it
>> > isn't used.  Since we only need this with __KERNEL__, move the include
>> > down to the right spot.  Now userland no longer needs to pull this in.
>> 
>> I don't understand what the problem is.
> 
> the exported linux/mii.h userspace code doesn't need linux/ethtool.h, thus it 
> should not need to include it

So there's not bug, you're just twiddling.

I don't think there should be any rule that just because the stuff
needed by a header is in __KERNEL__ we have to put the include in
there too, if the header in question is userspace clean itself.

It's so damn ugly, and error prone during audits (ie. easy to miss),
to have include directives not at the top of the file.

So I'm really not interested at all in applying patches like this
one, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html