netdev - Re: [PATCH net-next V2] gro: introduce gro_mac_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG4TOxO2ngyfFAM4njQW6keujOkRH_SEY9+02BYKJNmzGv69kg@mail.gmail.com>
Date:	Mon, 6 Feb 2012 11:59:15 -0800
From:	Roland Dreier <roland@...nel.org>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, ogerlitz@...lanox.com,
	sean.hefty@...el.com, herbert@...dor.hengli.com.au,
	linux-rdma@...r.kernel.org, shlomop@...lanox.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next V2] gro: introduce gro_mac_header_len

> Actually there is a way to make this work.
>
> Define your ipoib_skb_cb something like:
>
> struct ipoib_skb_cb {
>        struct qdisc_skb_cb     qdisc_cb;
>
>        ... ipoib stuff goes here ...
> };
>
> That way you can use the SKB cb area for your ipoib info
> without interfering with the packet scheduler.

Not sure I see how this could work.  sch_generic.h has:

struct qdisc_skb_cb {
        unsigned int            pkt_len;
        long                    data[];
};

and ipoib has no way of knowing what the biggest
scheduler-specific use of data[] will be.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html