netdev - Re: [PATCH] bcma: don't fail for bad SPROM CRC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F3029EC.3070709@broadcom.com>
Date:	Mon, 6 Feb 2012 20:28:44 +0100
From:	"Arend van Spriel" <arend@...adcom.com>
To:	Rafał Miłecki <zajec5@...il.com>
cc:	"Henrik Rydberg" <rydberg@...omail.se>,
	"John W. Linville" <linville@...driver.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>
Subject: Re: [PATCH] bcma: don't fail for bad SPROM CRC

On 02/06/2012 06:08 PM, Rafał Miłecki wrote:
> 2012/2/6 Henrik Rydberg <rydberg@...omail.se>:
>> The brcmsmac driver is now checking the bcma SPROM CRCs, leaving some
>> chipsets unrecognized that were functional prior to the switch. In
>> particular, the current code bails out on recent Macbooks. This patch
>> simply ignores the outcome of the CRC check, with the argument that an
>> unrecognized SPROM should be treated similarly to a non-existing one.
> 
> Have you maybe tried to look at the real solution?
> 

It could be a new SPROM revision, but brcmsmac still does SPROM access
on its own accord and would fail the probe sequence. So it is probably
something else.

SPROM configuration can differ between chipsets and have the following
variations:

1) external SPROM: when following conditions are true
	chipcommon.capabilities & 0x40000000
	chipcommon.sromcontrol & 0x00000001
2) on-chip OTP: when following conditions are true
	for 4313: chipcommon.chipstatus & 2
	for 43224/43225: true

The real solution would be to take the variations into account. I
started tinkering on it, but not completed yet.

Gr. AvS

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html