[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120207.153325.1941809701255235550.davem@davemloft.net>
Date: Tue, 07 Feb 2012 15:33:25 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: roland@...nel.org
Cc: eric.dumazet@...il.com, ogerlitz@...lanox.com,
sean.hefty@...el.com, herbert@...dor.hengli.com.au,
linux-rdma@...r.kernel.org, shlomop@...lanox.com,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next V2] gro: introduce gro_mac_header_len
From: Roland Dreier <roland@...nel.org>
Date: Tue, 7 Feb 2012 11:51:46 -0800
Overall, looks great.
> @@ -843,9 +837,8 @@ static int ipoib_hard_header(struct sk_buff *skb,
> if (dst)
> n = dst_get_neighbour_noref_raw(dst);
> if ((!dst || !n) && daddr) {
> - struct ipoib_pseudoheader *phdr =
> - (struct ipoib_pseudoheader *) skb_push(skb, sizeof *phdr);
> - memcpy(phdr->hwaddr, daddr, INFINIBAND_ALEN);
> + struct ipoib_cb *cb = (struct ipoib_cb *) skb->cb;
> + memcpy(cb->hwaddr, daddr, INFINIBAND_ALEN);
I would simplify this to "!skb_dst(skb)", any failure of
dst_get_neighbour_noref_raw() (now and in the future) would be
transient.
You're trying to see if this is a "neigh resolvable" path or not, and
the correct test for that is whether a dst is attached to the SKB.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists