netdev - Re: [PATCH] net: Default UDP and UNIX diag to 'n'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALUN=qKmdN=BP+edZRr50zH_rJe=twbHE7EKq6bCEptoHmBtyw@mail.gmail.com>
Date:	Tue, 7 Feb 2012 22:01:09 +0100
From:	Anisse Astier <anisse@...ier.eu>
To:	David Miller <davem@...emloft.net>
Cc:	xemul@...allels.com, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH] net: Default UDP and UNIX diag to 'n'.

On Tue, Feb 7, 2012 at 7:36 PM, David Miller <davem@...emloft.net> wrote:
> From: Anisse Astier <anisse@...ier.eu>
> Date: Tue, 7 Feb 2012 18:39:11 +0100
>
>> On Tue, 07 Feb 2012 12:29:31 -0500 (EST), David Miller <davem@...emloft.net> wrote :
>>
>>> From: Pavel Emelyanov <xemul@...allels.com>
>>> Date: Tue, 07 Feb 2012 17:37:51 +0400
>>>
>>> > @@ -409,7 +409,7 @@ config INET_TCP_DIAG
>>> >
>>> >  config INET_UDP_DIAG
>>> >    tristate "UDP: socket monitoring interface"
>>> > -  depends on INET_DIAG
>>> > +  depends on INET_DIAG && IPV6
>>>
>>> This needs to be something like "INET_DIAG && (IPV6 || IPV6=n)"
>>
>> Yes, this works better. This is the right solution.
>>
>> Tested-by: Anisse Astier <anisse@...ier.eu>
>
> The patch was corrupted by your email client, it turned all the
> tab characters into spaces, you also didn't write an appropriate
> commit message.
>
> I took care of this, but if you plan to submit any patch at all in
> the future, even as an "request for comments" and testing, you must
> keep these issues in mind.

Sorry, I didn't expect anyone to use this as a patch (no sign-off, etc),
so I shouldn't have posted a diff.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html