netdev - Re: [PATCH] net: sh_eth: fix skb_over

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 07 Feb 2012 08:55:10 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@...esas.com>
Cc:	netdev@...r.kernel.org,
	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
Subject: Re: [PATCH] net: sh_eth: fix skb_over_panic happen

Le mardi 07 février 2012 à 15:54 +0900, Shimoda, Yoshihiro a écrit :
> When this GETHER controller received a large frame (about 1800 bytes
> or more), skb_over_panic() happened. This is because the previous
> driver set the RFLR to 0x1000 (4096 bytes) and the skb allocate size
> is smaller than 4096 bytes. So, the controller accepted such a frame.
> 
> The controller can discard a large frame by the RFLR setting.
> So, the patch modifies the value of RFLR to mtu + ETH_HLEN +
> ETH_FCS_LEN.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> ---
>  drivers/net/ethernet/renesas/sh_eth.c |    2 +-
>  drivers/net/ethernet/renesas/sh_eth.h |    3 ---
>  2 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 813d41c..9e899b0 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -817,7 +817,7 @@ static int sh_eth_dev_init(struct net_device *ndev)
>  		sh_eth_write(ndev, 0, TRIMD);
> 
>  	/* Recv frame limit set register */
> -	sh_eth_write(ndev, RFLR_VALUE, RFLR);
> +	sh_eth_write(ndev, ndev->mtu + ETH_HLEN + ETH_FCS_LEN, RFLR);
> 

No VLAN_HDR ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html