lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 06 Feb 2012 16:46:33 -0800 From: Joe Perches <joe@...ches.com> To: Stephen Hemminger <shemminger@...tta.com> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH] tun: use ethtool msglevel bit mask convention On Mon, 2012-02-06 at 16:31 -0800, Stephen Hemminger wrote: > Replace custom debug printk with standard network device message level > interface. The messages about open/close/read/write are debug messages which can > be enabled at compile time or dynamic debug. Seems sensible. trivial comments below: > --- a/drivers/net/tun.c 2012-01-10 10:56:57.027157981 -0800 > @@ -381,7 +355,8 @@ static netdev_tx_t tun_net_xmit(struct s > { > struct tun_struct *tun = netdev_priv(dev); > > - tun_debug(KERN_INFO, tun, "tun_net_xmit %d\n", skb->len); > + netif_info(tun, tx_queued, dev, > + "tun_net_xmit %d\n", skb->len); Fits on a single line > @@ -1147,7 +1129,7 @@ static int tun_set_iff(struct net *net, > goto failed; > } > > - tun_debug(KERN_INFO, tun, "tun_set_iff\n"); > + netif_info(tun, drv, tun->dev, "tun_set_iff flags %#x\n", ifr->ifr_flags); This one is a little long. > @@ -1277,7 +1259,8 @@ static long __tun_chr_ioctl(struct file > if (!tun) > goto unlock; > > - tun_debug(KERN_INFO, tun, "tun_chr_ioctl cmd %d\n", cmd); > + netif_info(tun, drv, tun->dev, > + "tun_chr_ioctl cmd %#x\n", cmd); Another one on a single line. > @@ -1294,7 +1277,8 @@ static long __tun_chr_ioctl(struct file > /* Disable/Enable checksum */ > > /* [unimplemented] */ > - tun_debug(KERN_INFO, tun, "ignored: set checksum %s\n", > + netif_info(tun, drv, tun->dev, > + "ignored: set checksum %s\n", > arg ? "disabled" : "enabled"); I'd write this one on 2 lines as: netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n", arg ? "disabled", "Enabled"); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists